Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: deploy website with github actions #1767

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Conversation

bjohansebas
Copy link
Member

Deploy with GitHub Actions to better manage our deployment environment, plus now having all three environments with the same Ruby version. This is part of the work for #1747

@bjohansebas bjohansebas requested review from a team as code owners February 5, 2025 15:50
Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 174d0af
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/67a388df9177fe0008c965ed
😎 Deploy Preview https://deploy-preview-1767--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bjohansebas bjohansebas added maintenance Issues/PRs related to making the website maintainable build labels Feb 5, 2025
@crandmck
Copy link
Member

crandmck commented Feb 6, 2025

I don't have rights to approve the buby/ruby-setup action. Someone else on the TC should, I presume.

@carlosstenzel
Copy link
Contributor

And the pull_request will not be working?

@bjohansebas
Copy link
Member Author

It's for deploying the site to production, meaning the content that's on the gh-pages branch. Now, all three environments — development, Netlify (Pull request), and production — will use the same version and dependencies. I don't understand the reason for the pull_request in the CI.

@UlisesGascon, can you help us with this please?

@carlosstenzel
Copy link
Contributor

We currently have a preview in the pull request that helps a lot with the review

@bjohansebas
Copy link
Member Author

Yep, but that is a different integration, with another platform. We can't do anything with this CI, and we shouldn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build maintenance Issues/PRs related to making the website maintainable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants