a11y fix: header navigation landmark (primary navigation) #1848
+12
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This is no longer working. Try switching between languages multiple times. |
ShubhamOulkar
commented
Mar 30, 2025
| {% endif %} | ||
|
|
||
| {% include header.html %} |
There was a problem hiding this comment.
I made layout changes because a11y tools failed the landmark test on the home page. The issue was that the header was a descendant of section, causing it to lose its default role="banner".
There was a problem hiding this comment.
Replay to #1848 (comment)
It affected home layout all other layouts are 🆗.
There was a problem hiding this comment.
I forgotten to update translated 'index.md' files.
|
Fixed issue from #1848 (comment) in 771de1a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1807