-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record response time at response end instead of response start #165
Record response time at response end instead of response start #165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you add this as an option instead of changing the behavior?
Also the docs need to be updated (though since this should be a new option, add new docs). Here is the current docs:
|
Hi @dougwilson , thanks for your suggestion ! |
Hi @bobwei sorry I never came back to this PR. I just realized that instead of landing this as a flag that changes the behavior of an existing token, we should modify the PR to just add a new token with the behavior, which same the same ultimate outcome, but the benefit of being able to include both of these times in the output if that's desired. |
I have just written all the code to move this to a |
Hi @dougwilson, sure, please proceed. |
Can this be merged please? |
Go go |
closes #165
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebased the changes and they are ready to ship
Should record response time at response end instead of response start so that we can record whole response time for streaming response.