Session Touch Reduction Option #892
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The touch action is meant for any session activity. If you need some other type of mechanism, please open an issue with what you are trying to achieve and we can work on some interface for it. Just based on the referenced issue, it seems there is confusion on what the purpose of touch is for. |
|
@dougwilson - I legit opened an issue and linked it the description :)
|
|
Right, but that is the purpose of touch -- to be called every time there is activity on the session. If the store needs to throttle to it's storage mechanism, that is a store-specific concern that should be implemented in the store module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #891