Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some repositories and some labels #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bjohansebas
Copy link
Member

This adds some repositories that might be important and includes the tc agenda label as part of the list of labels to display on the page.

@@ -37,16 +40,19 @@ const config = module.exports.config = async (c = {}) => {
'expressjs/serve-static',
'expressjs/errorhandler',
'expressjs/serve-index',
'expressjs/security-wg',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am on the fence for these ones. The original idea was to only have ones which are published and active. How does the badge board look for this? Same for the .github ones.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The security-wg repository would be good to include, like the discussion one, since that place will have issues that could be of interest to the collaborators

I will delete the .github ones

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wonder if we need a flag for which should go on the badge board so we dont have empty rows for the "discussion" type repos?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a good option to add to the package in pkgs

@bjohansebas
Copy link
Member Author

Is there any package in the list that I should remove?

@wesleytodd
Copy link
Member

https://expressjs.github.io/statusboard/projects

It is a bit miss-leading to have admin and discussions loading badges from packages published to npm. That was my worry about having those in here.

@bjohansebas
Copy link
Member Author

If we remove discussions, many of the issues imported to this page would be removed, which I don't think we should do as it would lose several discussions from that repository.

As for Admin, I'm not sure what the future of that repository will be, but I assume it will be something similar to how it is in Node.js

@wesleytodd
Copy link
Member

Yep, just wanted to make sure I pointed it out. I don't know if we should try to wait to land a feature to filter it out or if it is alright.

@bjohansebas
Copy link
Member Author

It would be fine like this for now, that's how it worked before we made it work again. I'll open an issue later to keep it in mind for pkgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants