Do not use class names as string literals

[larsroettig]

Rule

Warning for String-Representation in $this->createMock for Unit Test.

Reason

if you use String Representation typos can happen also it not nice for IDEs Usage Analyse

Implementation

Bad Example:

$this->createMock('\Foo\Bar\Baz');

Recommendation Example:

$this->createMock(\Foo\Bar\Baz::class);

[lenaorobei]

This issue is related not only to unit tests but to code in general. It is already implemented in EQP coding standard, as well as in Magento 2 core static checks.

https://github.com/magento/marketplace-eqp/blob/master/MEQP2/Sniffs/Classes/NameResolutionSniff.php

https://github.com/magento/magento2/blob/2.2-develop/dev/tests/static/framework/Magento/Sniffs/LiteralNamespaces/LiteralNamespacesSniff.php

[larsroettig]

Hi @lenaorobei, cool thank you maybe we can discuss this at the community Meeting.

[schmengler]

It should definitely become a rule not to use class names as string literals. What we need is a decision how to best integrate this rule into extdn-phpcs. I would rather not rely on a Magento code base being available and class_exists/interface_exists then only work with names from the extension itself.

[schmengler]

A discussed idea was to look for arguments of certain methods like “ObjectManager::create()” but there are many possibilities where a class name can be used as string.

We will try to implement the rule with a regular expression instead, using a low warning level, and try out if any false positives occur. The MEQP rule can be included as an addition – if there is no Magento installation, it will just find nothing.