Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include and document MEQP2.Templates.ThisInTemplate #40

Merged
merged 3 commits into from
May 29, 2018

Conversation

schmengler
Copy link
Collaborator

Description

The sniff MEQP2.Templates.ThisInTemplate gets included. It checks for deprecated usage of $this in PHTML templates.

The Marketplace Extension Quality Program (MEQP2) has been added as composer requirement.

Sniff checklist

  • Sniff is accompanied by unit test
  • Sniff is documented using the documentation template (FooSniff.md next to FooSniff.php)

@schmengler schmengler force-pushed the MEQP2.ThisInTemplate branch from 5de2a28 to d523606 Compare May 28, 2018 13:52
@schmengler schmengler force-pushed the MEQP2.ThisInTemplate branch from d523606 to 42040d1 Compare May 28, 2018 14:00
@andrewhowdencom
Copy link

Super nice!

@schmengler schmengler merged commit ebd28e5 into master May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants