Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings chapter again (and again) #36

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

CGMossa
Copy link
Member

@CGMossa CGMossa commented Jul 2, 2024

Somehow, this chapter got deleted.

I don't think it flows at all and could use some heavy suggestions.. But here it is!

@CGMossa CGMossa requested a review from kbvernon July 2, 2024 15:43
Copy link
Collaborator

@kbvernon kbvernon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions here:

  1. Add an introduction that briefly explains what the reader can expect to get out of this article.
  2. Demonstrate the challenges of working with character strings in the R+Rust context using some examples involving Rust and extendr types - String, Rstr, Strings, Vec<String> - and show some common errors that you think are likely to come up.
  3. Include references to The Book: https://doc.rust-lang.org/book/ch04-01-what-is-ownership.html and https://doc.rust-lang.org/book/ch08-02-strings.html. If you think there are other sources that could be helpful, include those, too.

@CGMossa CGMossa marked this pull request as draft July 3, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants