Correct windows testing #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andy-thomason, here is the Win-32 issue I mentioned earlier. |
|
The reason is no support for cross-compilation of doc tests, |
clauswilke
reviewed
Jan 29, 2021
clauswilke
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest adding an additional set of bindgen tests (or replace the existing one) to allow correct testing of Windows 32-bit builds.
This script is not trivial, as we need more than one Rust toolchain.
It also has linking issues with
stable-i686-gnutoolchain (see rust-lang/cargo#8990), but there is a bypass.Again, the purpose of this config is to show that there are issues in Win-32 build which our tests previously did not reveal (but now do).
NB: I left MacOS and Ubuntu configurations enabled to verify it also works for other systems as is. I can disable/remove unused targets to preserve computational resources.