Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Documents action #172

Merged

Conversation

yutannihilation
Copy link
Contributor

As of v1.0.9, which was released 3 weeks ago, actions/upload-pages-artifact rejects files with incorrect permission. Before that, the action kindly corrected the permission, so our CI passed with this warning:

Warning: mode of './target/doc/.lock' changed from 0600 (rw-------) to 0644 (rw-r--r--)

(https://github.com/extendr/libR-sys/actions/runs/5113126789/jobs/9191980916#step:6:31)

But, now, it's our job to handle these files. This pull request removes the unused file .lock.

See actions/deploy-pages#188 for more details.

Copy link
Member

@CGMossa CGMossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yutannihilation
Copy link
Contributor Author

Thanks.

@yutannihilation yutannihilation merged commit e1a740e into extendr:master Jul 7, 2023
@yutannihilation yutannihilation deleted the ci/fix-docments-action branch July 7, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants