-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental: Migrate to Rspack #156
base: main
Are you sure you want to change the base?
Conversation
0115308
to
13b2772
Compare
Updates Aug, 24thReloader plugin isn't working, which means manifest.json, service_worker and content_scripts are not reloading. Can't connect to the websocket server and requires a full migration of https://github.com/awesome-webextension/webpack-target-webextension to Rspack. I made a few adjustments to make it compile but it's far from working. Migration is doing well so far during tests and almost everything else works including the multiple CSS/JS integrations. |
549757a
to
5931a35
Compare
Updates Aug, 27thReloader plugin is working partially. Websocket server work is done. The manifest.json, service_worker and content_scripts files are still not reloading and requires a full migration of https://github.com/awesome-webextension/webpack-target-webextension to Rspack. The manifest.json file should be working already given it's not part of Having the reload step done this PR will be ready to merge. I plan to have it in the final version of 2.0.0. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
cc @OSpoon are you familiar with Rspack? I need a hand figuring out why Rspack isn't watching the manifest.json file (I'm testing with the |
Are you planning to abandon Webpack and fully embrace Rspack? I'm not familiar with Rspack, but I can try to learn about it. This would be helpful for me in the future. |
@OSpoon if all works well, yes. Rspack has some advantages like a faster cold start, faster compilation time (for our templates, time is reduced by 2x/3x), overall smaller package sizes, and decent integration with the webpack ecosystem. The plan for v2 is that users are requesting a way to extend Extension.js via config files and exposing webpack once would make it very hard to migrate later. |
@cezaraugusto I found that I might not fully understand the exact reason why it doesn't work. |
5931a35
to
70aaee7
Compare
commit: |
commit: |
3880399
to
8edf2f1
Compare
I haven't worked with Rspack and don't know how these bundlers work under the hood, but in my experience with Jonghakseo's and especially NekitCorp's boilerplates, Vite was blazing fast. Rspack is written in Rust though, so it seems very promising. |
@dandv yeah, so Extension.js is built on top of webpack and Rspack is faster and supports most of its API. I'll get back to this once we can make the reload plugin work with Rspack |
No description provided.