Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully cross-browser templates #196

Merged
merged 3 commits into from
Sep 22, 2024
Merged

Fully cross-browser templates #196

merged 3 commits into from
Sep 22, 2024

Conversation

cezaraugusto
Copy link
Member

@cezaraugusto cezaraugusto commented Sep 21, 2024 •
edited
Loading

  • UI parity across templates
  • Avoid usage of browser-specific APIs
  • Use browser-specific manifest fields when appropriate
  • Each template has its own logo in /public even if not used

@cezaraugusto cezaraugusto self-assigned this Sep 21, 2024
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 21, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/extension-js/extension.js/extension@196

pnpm add https://pkg.pr.new/extension-js/extension.js/extension-create@196

pnpm add https://pkg.pr.new/extension-js/extension.js/extension-develop@196

commit: b1fc141

@cezaraugusto cezaraugusto force-pushed the cross-browser-templates branch 7 times, most recently from 9fb3681 to c499092 Compare September 22, 2024 16:05
@codecov Codecov
Copy link

codecov bot commented Sep 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

see 7 files with indirect coverage changes

@cezaraugusto cezaraugusto force-pushed the cross-browser-templates branch from c499092 to f6e2b49 Compare September 22, 2024 16:14
@cezaraugusto cezaraugusto force-pushed the cross-browser-templates branch from f6e2b49 to b30653e Compare September 22, 2024 16:39
@cezaraugusto cezaraugusto marked this pull request as ready for review September 22, 2024 17:24
@cezaraugusto cezaraugusto merged commit d34b3c6 into main Sep 22, 2024
13 of 15 checks passed
@cezaraugusto cezaraugusto deleted the cross-browser-templates branch September 22, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cezaraugusto cezaraugusto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cezaraugusto