Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

imagePullSecrets is not correctly added to values.yaml #522

Closed
balazs-fark-epam opened this issue Oct 22, 2020 · 1 comment · Fixed by #577
Closed

imagePullSecrets is not correctly added to values.yaml #522

balazs-fark-epam opened this issue Oct 22, 2020 · 1 comment · Fixed by #577
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@balazs-fark-epam
Copy link

In https://github.com/godaddy/kubernetes-external-secrets/blob/master/charts/kubernetes-external-secrets/values.yaml
imagePullSecrets is child of image:

image:
  repository: godaddy/kubernetes-external-secrets
  tag: 6.0.0
  pullPolicy: IfNotPresent
  imagePullSecrets: []

but it templates/deployment.yaml:

it is referenced like

      {{- if .Values.imagePullSecrets }}
      imagePullSecrets:
        {{- toYaml .Values.imagePullSecrets | nindent 8 }}
      {{- end }}
@Flydiverny Flydiverny added the good first issue Good for newcomers label Oct 22, 2020
@vividh
Copy link

vividh commented Oct 26, 2020

Hi, I would like to work on this!

Flydiverny added a commit that referenced this issue Dec 9, 2020
@Flydiverny
fix(values): imagePullSecrets was wrongly indented under image
60f2ee3 
solves #522
@Flydiverny Flydiverny mentioned this issue Dec 9, 2020
Merged
@Flydiverny Flydiverny added the bug Something isn't working label Dec 9, 2020
Flydiverny added a commit that referenced this issue Dec 22, 2020
@Flydiverny
fix(values): imagePullSecrets was wrongly indented under image (#577)
7861473 
solves #522
@Flydiverny Flydiverny mentioned this issue Dec 22, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
3 participants
@Flydiverny @vividh @balazs-fark-epam