Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subreddit flairs hiding/showing when hovering over posts #659

Closed
kamssiopeia opened this issue Jan 18, 2021 · 9 comments
Closed

Subreddit flairs hiding/showing when hovering over posts #659

kamssiopeia opened this issue Jan 18, 2021 · 9 comments
Labels

Comments

@kamssiopeia
Copy link

kamssiopeia commented Jan 18, 2021

ATTENTION! If you don't follow this template then your issue will be immediately closed.

Description of the problem

When hovering over links with flairs on reddit, flairs show and hide causing website to "jump". Gif with issue https://i.fiery.me/nidPm.gif. When addon is disabled problem doesn't occur

Url of the page where the problem occurs (not the image url)

https://www.reddit.com/r/formula1/

Steps to reproduce the problem (include image url here)

  1. go to subreddit with flairs, eg. formula1
  2. hover over link with flair
  3. flairs hide when hovering on links and show again when hovering off

OS version, extension version (Chrome only, Firefox is not supported)

1.0.163

@GrosPoulet
Copy link
Contributor

Hi @dzienskaj
I did not manage to reproduce this issue: the helmet image is displayed fullsize and does not hide until i hover out of the link.
Do you experience this issue on others links ?

@kamssiopeia
Copy link
Author

Hi @dzienskaj
I did not manage to reproduce this issue: the helmet image is displayed fullsize and does not hide until i hover out of the link.
Do you experience this issue on others links ?

Hey, image loading is not a problem here, addon itself works great, but it's causing small "art" flair near title that im hovering to hide/show all the time, causing page to jump around and because of that it's harder to hover over links

@extesy extesy added the bug label Jan 19, 2021
@kamssiopeia
Copy link
Author

From what i've noticed, when I hover on the link flairs hide (all flairs on given page), and when i hover off they show again, also when you fast move over a link so that hoverzoom modal doesn't appear, they hide until you hover on link again.

@extesy
Copy link
Owner

extesy commented Jan 19, 2021

Yes, I've seen this happening. I personally only use "old" reddit so maybe it's related to the old reddit design?

@kamssiopeia
Copy link
Author

kamssiopeia commented Jan 19, 2021

@extesy i only use old reddit aswell, never checked it on new design. Will check new reddit tomorrow.

Edit: I was checking what happens in html and it seems that title is cleared https://i.fiery.me/rDxVb.gif, if you remove hoverZoomLink class from <a> tag it works as intended but hover zoom doesn't work :P. No idea if it helps, but i thought i would post it

@extesy
Copy link
Owner

extesy commented Jan 20, 2021

@GrosPoulet FYI, this can be reproduced on reddit (https://www.reddit.com/r/formula1/ is an easy example) under two conditions: 1) old reddit design, 2) "use subreddit style" is on. This is caused by removeTitles/restoreTitles functions in hoverzoom.js, but I haven't yet checked if that is truly necessary to do and if there are any workarounds.

@dzienskaj if you set "use subreddit style" to off, the problem seems to disappear.

@extesy
Copy link
Owner

extesy commented Jan 20, 2021

I've commented out the call to removeTitles() and current test-driving the results. I haven't yet seen any rogue tooltips popping up.

@extesy extesy closed this as completed in a9c02a7 Jan 20, 2021
@extesy
Copy link
Owner

extesy commented Jan 21, 2021

Ok, I found that not removing titles causes problems with https://imdb.com so I guess I'll have to make this an option then.

@kamssiopeia
Copy link
Author

@extesy Thank you guys for fixing this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants