Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to browser history not working on old.reddit.com #881

Closed
mobad opened this issue Feb 20, 2022 · 4 comments
Closed

Add to browser history not working on old.reddit.com #881

mobad opened this issue Feb 20, 2022 · 4 comments
Labels

Comments

@mobad
Copy link

mobad commented Feb 20, 2022

Describe the bug
Links aren't turning purple on https://old.reddit.com/r/all/ when hovered over.

To Reproduce
Steps to reproduce the behavior:

  1. Enable add to browser history.
  2. Browse to https://old.reddit.com/r/all/
  3. Hover over various links and see that they aren't turning purple (added to history)

Expected behavior
The links should turn purple when hovered over.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Linux
  • Browser Chrome
  • Version 98.0.4758.102

Additional context
This only started happening after the update to 1.0.188, most likely due to 5ff674b
I suspect because the image url is actually different from the link URL.
I think most likely you'd need to add both to history?

@extesy
Copy link
Owner

extesy commented Feb 20, 2022

@GrosPoulet Can you take a look? I did mention that the removed lines were originally added to fix reddit.

@extesy extesy added the bug label Feb 20, 2022
@JunoArc
Copy link

JunoArc commented Feb 20, 2022

Getting same issue

OS: Win10
Browser Chrome
Version 98.0.4758.102 (Official Build)

GrosPoulet added a commit to GrosPoulet/hoverzoom that referenced this issue Feb 20, 2022
GrosPoulet added a commit that referenced this issue Feb 20, 2022
GrosPoulet added a commit to GrosPoulet/hoverzoom that referenced this issue Feb 20, 2022
GrosPoulet added a commit that referenced this issue Feb 20, 2022
@extesy
Copy link
Owner

extesy commented Feb 20, 2022

@mobad @JunoArc Should be fixed in 1.0.189. Can you please confirm if the feature works properly now?

@mobad
Copy link
Author

mobad commented Feb 20, 2022

@extesy Works for me now! Thanks @GrosPoulet !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants