Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't load images from preview.redd.it #924

Closed
kbuffington opened this issue May 11, 2022 · 6 comments
Closed

Can't load images from preview.redd.it #924

kbuffington opened this issue May 11, 2022 · 6 comments

Comments

@kbuffington
Copy link

Description of the problem

HoverZoom seems to work on every image source on Reddit, except for preview.redd.it.

Url of the page where the problem occurs (not the image url)

https://www.reddit.com/r/gaming/comments/unj1se/it_hurts/

Steps to reproduce the problem (include image url here)

  1. Open Reddit
  2. Hover zoom over a link preview.redd.it link (i.e. https://preview.redd.it/qyra0saiowy81.gif?width=750&format=mp4&s=592dfb87dcff3da19ae9223f12576a899594cc4f)
  3. Error is thrown in console saying link could not be loaded

OS version, extension version

OSX, extension version 1.0.190

@kbuffington
Copy link
Author

This is broken again:

image

@extesy
Copy link
Owner

extesy commented Jun 21, 2022

@kbuffington Does it happen on a different page? https://www.reddit.com/r/gaming/comments/unj1se/it_hurts/ works for me, although I'm using the master branch, not yet released.

@kbuffington
Copy link
Author

It doesn't even work for me on this github page.

Also, I think that post you linked was removed because I can't see anything :)

@extesy
Copy link
Owner

extesy commented Jun 21, 2022

I linked the same post you linked in your bug description. It opens correctly for me in the browser. The main priority is to make sure reddit preview links work on reddit, not on github.

@kbuffington
Copy link
Author

kbuffington commented Jun 22, 2022

Weird. That reddit link doesn't work for me at all. Hovering over any preview.redd.it link doesn't work for me, regardless of page, and they all give the same "failed to load image" error. Here's another reddit page showing the same issue: https://www.reddit.com/r/gaming/comments/vh4sq9/the_sassiest_assassin_arno_dorian_assassins_creed/

@extesy
Copy link
Owner

extesy commented Jun 22, 2022

Ah, you seem to be using the "new" reddit. I'm always using the "old" one as a default interface. Your link works in the old reddit but not in the new one. I'll take a look.

@extesy extesy reopened this Jun 22, 2022
@extesy extesy closed this as completed in 0c789ca Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants