Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tapas.io plugin #1287

Merged
merged 2 commits into from
Jan 14, 2024
Merged

Implement tapas.io plugin #1287

merged 2 commits into from
Jan 14, 2024

Conversation

weshead
Copy link

@weshead weshead commented Jan 12, 2024

Overview

This introduces functionality for the tapas.io website. The changes allow the extension to discover and prepare images from tapas.io.

Details

  • Added a new plugin for tapas.io in the hoverZoomPlugins array.
  • The plugin includes a configuration object for tapas.io specific selectors and classes.
  • Implemented awaitDom function to wait for an element to appear in the DOM.
  • Implemented prepareComics function to prepare the comics for HoverZoom+ to discover.
  • The plugin initiates an episode listener that triggers prepareComics when new images load.

Impact

These changes add support for the tapas.io website to the hoverZoom plugin, enhancing the plugin's functionality.

manifest.json Outdated Show resolved Hide resolved
@weshead weshead requested a review from extesy January 13, 2024 19:51
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
1.1% Duplication on New Code

See analysis details on SonarCloud

@extesy extesy merged commit 23828b6 into extesy:master Jan 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants