New plug-in for: StartPage search engine #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extesy
reviewed
Dec 5, 2021
| // Return JSON object corresponding to path, without using the Evil eval | ||
| // path syntax: [key1][key2][key3]... | ||
| function getJsonObjectFromPath(path) { | ||
| return new Function('return ' + spJson + path)(); |
There was a problem hiding this comment.
@GrosPoulet This is unsafe code which is banned by Mozilla, please take a look at my fix in 98a6d97
There was a problem hiding this comment.
@extesy I don't see what's wrong but i trust Mozilla, they are certainly more experts that i am 😄
I'll apply your changes to StartPage plug-in & move following functions to hoverzoom.js:
- getJsonObjectFromPath
- getKeysInJsonObject
- getValuesInJsonObject
There was a problem hiding this comment.
Yeah, it makes sense to move these functions to a common code since they are used across multiple plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.