Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specs and formatting #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Specs and formatting #14

wants to merge 2 commits into from

Conversation

InoMurko
Copy link

@InoMurko InoMurko commented Oct 5, 2018

  • Bumped up dialyxir and credo.
  • Fixed all dialyzer errors.
  • Added formatter file and formatted the files.
  • Set circle checks for dialyzer and formatter.

hayesgm
hayesgm approved these changes Oct 6, 2018
View reviewed changes
Copy link
Contributor

@hayesgm hayesgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. we'll need to re-run this patch on https://github.com/exthereum/ethereum as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayesgm hayesgm hayesgm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@InoMurko @hayesgm