[#7] User can view / edit number of arrests on Rebel #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks ! As potential future contributor, I was looking for seeds and you provided it to me ;) |
|
Thanks a lot @kvrag! I will review before Monday. |
kvrag
commented
Oct 18, 2019
| td(style="width: 10rem") | ||
| td | ||
| = rebel.number_of_arrests.presence || "-" | ||
| td(style="width: 5rem") |
There was a problem hiding this comment.
I changed the width here because the icon doesn't require 10rem of space, and the table was starting to look a little squished with the new column.
There was a problem hiding this comment.
Yes, the table is becoming a real mess. We'll work on that.
mhulet
reviewed
Oct 23, 2019
| @@ -42,7 +44,7 @@ div(data-controller="datatable" data-datatable-export-title="#{FFaker::Music.son | |||
| tr(id="selected-id-#{rebel.id}" data-object-id="#{rebel.id}" data-rebel-name="#{rebel.name}") | |||
| td | |||
| td | |||
| => link_to (rebel.name.present? ? rebel.name : "-"), | |||
| => link_to (rebel.name.presence || "-"), | |||
There was a problem hiding this comment.
Thanks @kvrag, I didn't know about this one 👍
mhulet
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7
Notes
Seeds
When I was setting up the project locally, I thought it might be easier for future contributors to test front-end changes if there were a few seed records. I can remove those from this PR if desired.
Annotations
When I ran the migration to add the column, I noticed that
annotatewasn't working. I searched around and it seems like perhaps that gem got updated somewhere along the way and needed a fresh install. So you'll see a bunch of annotation diffs in this PR as well.Questions
Do we want to add any specific validations on the number of arrests column?