Backport Linker API #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ough, there might be a bug 🤔 I'll create a reproducer if any |
|
uhmm, it might not be a bug, it's looking for an |
when is the last time we updated the runtime.wasm? i can't recall if i setup a process for that. |
|
it was a little old but I realized the real culprit was that we never implemented a bunch of host functions (like log_* or config_{get,set} etc) 😬 |
|
fixed with #11 |
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
evacchi
force-pushed
the
backported-linking
branch
from
6269863 to
e5d0629
Compare
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
|
Let's merge this to unblock the demo at https://github.com/evacchi/xtp-kafka-demo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport the API in #9 against Chicory 0.0.12 so that it can be used without waiting for a new upstream release, while we finalize things for 1.0.0. This is exactly the same as #9, except I am using the old 0.0.12 APIs to instantiate modules.