Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct fsharp print statements in README.md #87

Merged
merged 1 commit into from
May 16, 2024
Merged

correct fsharp print statements in README.md #87

merged 1 commit into from
May 16, 2024

Conversation

bradyjoslin
Copy link
Contributor

  • Added missing printfn statements for fsharp samples
  • Changed a sample using Console.WriteLine to use printfn to be consistent and idiomatic

@bhelx bhelx requested a review from mhmd-azeez May 16, 2024 16:45
mhmd-azeez
mhmd-azeez approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@mhmd-azeez mhmd-azeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@mhmd-azeez mhmd-azeez merged commit 8532ff2 into extism:main May 16, 2024
3 checks passed
@bradyjoslin bradyjoslin deleted the patch-1 branch May 16, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmd-azeez mhmd-azeez mhmd-azeez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradyjoslin @mhmd-azeez