chore: pin wazero to main commit for now #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nilslice any idea why this test is failing: https://github.com/extism/go-sdk/actions/runs/10889996025/job/30217772116?pr=75#step:5:46 |
|
@zshipko, hmm... I don't, but I have a change to that test here in #74 (unmerged): The failing test actual output includes a |
|
okay, thanks i will look into that! |
zshipko
force-pushed
the
pin-wazero-main
branch
from
addbf2d
to
f846daf
Compare
zshipko
force-pushed
the
pin-wazero-main
branch
from
f846daf
to
607be85
Compare
nilslice
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can wait until the next wazero release to make another release of the go-sdk, but for now using the latest wazero on main will unblock the testing of the python pdk