Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FFI code to latest 1.0 runtime changes #4

Closed
bhelx opened this issue Nov 15, 2023 · 1 comment · Fixed by #7
Closed

Update FFI code to latest 1.0 runtime changes #4

bhelx opened this issue Nov 15, 2023 · 1 comment · Fixed by #7
Assignees
@mhmd-azeez

Comments

@bhelx
Copy link
Contributor

bhelx commented Nov 15, 2023

Update the FFI code to work with v1.0.0 runtime, remove context, etc.
@bhelx bhelx self-assigned this Nov 15, 2023
@zshipko
Copy link
Contributor

zshipko commented Nov 15, 2023

The Context type has been removed already but there is likely some additional work needed to fix things up a bit.

@neuronicnobody neuronicnobody assigned mhmd-azeez and unassigned bhelx Nov 20, 2023
@neuronicnobody neuronicnobody added question Further information is requested and removed question Further information is requested labels Nov 27, 2023
@mhmd-azeez mhmd-azeez mentioned this issue Nov 29, 2023
Merged
9 tasks
mhmd-azeez added a commit that referenced this issue Dec 4, 2023
@mhmd-azeez
feat: update the SDK to use the latest changes in the Extism runtime (#7
6f37551 
)

- [x] Remove dependency on `ircmaxell/ffime`, instead we handwrite the
bindings. This enables us to supports Windows too.
- [x] Update the FFI to use the latest runtime APIs
- [x] Removed Context
- [x] Removed support for Cancel Handle (since PHP is single-threaded,
wasn't sure how one could use it)
- [x] Add support for Manifest
- [x] Update README
- [x] Add tests
- [x] Add inline docs
- [x] New CI

Fixes #4 and Fixes #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhmd-azeez mhmd-azeez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: update the SDK to use the latest changes in the Extism runtime extism/php-sdk
4 participants
@bhelx @zshipko @neuronicnobody @mhmd-azeez