Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add README #5

Closed
wants to merge 2 commits into from
Closed

docs: Add README #5

wants to merge 2 commits into from

Conversation

bhelx
Copy link
Contributor

@bhelx bhelx commented Nov 16, 2023

Just copying over the doc from extism.org for now so we can delete that one https://extism.org/docs/integrate-into-your-codebase/php-host-sdk. We can update this after merge.

@nilslice nilslice requested a review from G4Vi November 17, 2023 18:02
@nilslice
Copy link
Member

@G4Vi, just testing some notification activity in Slack and using your handle randomly. Feel free to ignore these & sorry if you get bombarded with messages.

Copy link
Contributor

@G4Vi G4Vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got the reminder. Let me know if I should actually review.

require_once __DIR__ . '/vendor/autoload.php';

// See the manifest docs for more options https://extism.org/docs/concepts/manifest
$wasm = (object) [ 'wasm' => [](object) [ 'path'] = './code.wasm']];
Copy link

@chrisdickinson chrisdickinson Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on php v8.3.0 (installed via homebrew) this throws a syntax error.

Suggested change
$wasm = (object) [ 'wasm' => [](object) [ 'path'] = './code.wasm']];
$wasm = (object) [ 'wasm' => (object) ['path' => './code.wasm']];

@bhelx
Copy link
Contributor Author

bhelx commented Jan 2, 2024

This is no longer valid I think

@bhelx bhelx closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants