chore: use php-discovery to find matching PHP build

[azjezz]

I currently have over 18 PHP installations locally, having to swipe between them for different projects is kinda annoying, so here's my solution for the problem :)

php-discovery will attempt to find all PHP builds in the system, even if not listed in PATH, and create a struct representing each build, containing all information necessary for ext-php-rs.

note: ext-php-rs will still have to do the work to get includes on windows, while i can certainly add it as a feature in php-discovery, i feel that it doesn't belong, and that it should do only 1 job, which is discover available PHP builds.

[ptondereau]

@azjezz thank you! This indeed remove a lot of code from build. I've approved the CI workflow

[azjezz]

ah! forgot to define php81! -- should pass now 🤞

[ju1ius]

Hi @azjezz,

While I appreciate your motivation and considerable efforts to improve the current situation, having a script taking ~10sec to scan my entire /usr directory, only to find exactly the same thing that which php finds in 5ms - that is to say not the right version because I keep all my custom PHP builds under my home directory - is not something I think I'll enjoy very much.

I'd rather have a simple environment variable override like PHP_PREFIX=<prefix> where <prefix> is the --prefix option passed to ./configure (which would imply <prefix>/bin/php and <prefix>/bin/php-config on unixes).
If PHP_PREFIX is not set, then just fallback to which php-config.

But hey, that's only my personal taste. 😉

[ptondereau]

Hi @azjezz,

While I appreciate your motivation and considerable efforts to improve the current situation, having a script taking ~10sec to scan my entire /usr directory, only to find exactly the same thing that which php finds in 5ms - that is to say not the right version because I keep all my custom PHP builds under my home directory - is not something I think I'll enjoy very much.

I'd rather have a simple environment variable override like PHP_PREFIX=<prefix> where <prefix> is the --prefix option passed to ./configure (which would imply <prefix>/bin/php and <prefix>/bin/php-config on unixes).

If PHP_PREFIX is not set, then just fallback to which php-config.

But hey, that's only my personal taste. 😉

Yes sometimes, I need to test with different compiled version of php (debug) and I know where to find it. In a build context, an environment variable could be more efficient.

[ju1ius]

having a script taking ~10sec to scan my entire /usr directory,

I stand corrected, it does perform some globbing so it's more like under a second, which is much better than I tought initially.

Still won't do anything useful in my particular case, but simplifying the build workflow is always nice ! 👍🏻

[azjezz]

i have added a soft-criteria for PHP version, which can be used to select which binary to use, for example, here i can select 8.1.0-dev ( i say soft because it won't fail if no matching build is found, but rather continue to grab the first one with a matching PHP API )

[azjezz]

( sorry about the repeated failure on windows, not testing it ^^" )

[azjezz]

passed ✔️

[azjezz]

^ removed unused import, won't have any effect on the build result

[ptondereau]

LGTM! Thank you!