-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the response result format #407
Comments
@mirsella yes, the latest update relates to |
hey ! return as author: "author": {
"@type": "Person",
"name": "Chris Baraniuk"
}, and as published, instead of the usual empty string when not finding a date, return null, on the latest version of this library, tested with the bun and deno version: "published": null, |
on your demo site https://extractor-demos.pages.dev/article-extractor this is still a empty string, so i guess its on a recent version that wasn't yet put on your site |
@mirsella yes, we should avoid the inconsistency. I will release a new version. |
personally i've adapted my code to match the api return so i dont "care" anymore, but updating the schema for new user would be nice, and avoid breaking change like this on a minor version bump (both author and published are breaking change) thanks, have a good day |
@mirsella your are right, I didn't carefully check the recent pr! |
awesome ! just missing the update response format in the readme, i would have done a PR but i don't know enough the project to says what exactly can be assigned to the field author like the @type |
@mirsella I try to keep the output structure as before. |
oh ok author is also getting it's previous comportement, nice |
this is no longer correct:
latest broke my application as the result for example author, is now something like
and published if not found, is now null instead of a empty string
The text was updated successfully, but these errors were encountered: