Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when read rich or phonetic with EOF,then read it at next continue #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gr258
Copy link

@gr258 gr258 commented Jul 20, 2018

In get_string function,when read rich or phonetic with EOF,the w.continue_rich and w.continue_apsb are not correct,it shout sub read count,then read the left count at next continue stream.

@extrame
Copy link
Owner

extrame commented Sep 5, 2018

I dont't think this patch is acceptable, you can add your change but you can't remove the other feature like removing ver5 support and others

make sure just add something and don't affect others.

@gr258
Copy link
Author

gr258 commented Sep 17, 2018

I dont't know the meaning of "removing ver5 support".In the first "else" branch, the w.Is5ver is false, so the next "if w.Is5ver " is a dead code,that's why i remove this condition.

code:
if w.Is5ver {
var bts = make([]byte, size)
_, err = buf.Read(bts)
res = string(bts)
} else {
......
if w.Is5ver {
seek_size = int64(2 * richtext_num)
} else {
seek_size = int64(4 * richtext_num)
}
......

}
for err == nil && offset_pre < len(wb.sst) {
var str string
if size > 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

God, t thought i am the first person who found a bug here. Same patch in my PR #50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants