improve performance on diffing giant files (#96)

extrawurst · May 29, 2020 · 732690d · 732690d
1 parent ff67122
commit 732690d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/asyncgit/src/sync/diff.rs b/asyncgit/src/sync/diff.rs
@@ -71,7 +71,7 @@ pub struct FileDiff {
  /// list of hunks
  pub hunks: Vec<Hunk>,
  /// lines total summed up over hunks
- pub lines: u16,
+ pub lines: usize,
 }
 
 pub(crate) fn get_diff_raw<'a>(
@@ -144,7 +144,7 @@ pub fn get_diff(
  header_hash: hash(header),
  lines: lines.clone(),
  });
- res.lines += lines.len() as u16;
+ res.lines += lines.len();
  };
 
  let mut put = |hunk: Option<DiffHunk>, line: git2::DiffLine| {

diff --git a/src/components/diff.rs b/src/components/diff.rs
@@ -172,7 +172,7 @@ impl DiffComponent {
 
  if Self::hunk_visible(hunk_min, hunk_max, min, max) {
  for (i, line) in hunk.lines.iter().enumerate() {
- if line_cursor >= min {
+ if line_cursor >= min && line_cursor <= max {
  Self::add_line(
  &mut res,
  width,