Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scrolling great again #144

Closed
x80486 opened this issue Jun 20, 2020 · 2 comments
Closed

Make scrolling great again #144

x80486 opened this issue Jun 20, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@x80486
Copy link

x80486 commented Jun 20, 2020

Describe the Bug

Scrolling on Unstaged Changes (or Staged) sections is a little bit weird. For instance, with a long list of files, when you reach the bottom and try to go back the highlighted line doesn't go to the top to start scrolling again, but it goes with the list.

Notice the Diff section behaves as one would expect.

To Reproduce

Steps to reproduce the behavior:

  1. Have a Git repo with a good amount of unstaged or staged files that will allow you to scroll
  2. Press the Down arrow until the bottom is reached
  3. Press the Up (several times)

Notice how the list moves with the press of every Up arrow along with the highlighted line, instead of just the highlighted line.

Expected Behavior

The list should stay in place until the top is reached, then it should move accordingly.

I filed this as a bug because the Diff section behaves correctly (for what I expect). This could have been an enhancement, or probably that's the intended behavior — in that case I would expect you to reconsider and possibly make it work like the Diff section!

Desktop

  • OS: Arch Linux Linux uplink 5.4.46-1-lts #1 SMP Wed, 10 Jun 2020 20:36:34 +0000 x86_64 GNU/Linux
  • Browser: N/A (why this matters anyway?)
  • Version: gitui 0.7.0
@extrawurst
Copy link
Owner

@x80486 you are absolutely right, this can be improved!

followup to #52

@extrawurst extrawurst added enhancement New feature or request good first issue Good for newcomers labels Jun 22, 2020
extrawurst pushed a commit that referenced this issue Jun 22, 2020
@extrawurst extrawurst modified the milestone: v0.8 Jun 23, 2020
@extrawurst extrawurst added this to the v0.8 milestone Jun 30, 2020
extrawurst pushed a commit that referenced this issue Jun 30, 2020
MCord pushed a commit to MCord/gitui that referenced this issue Jul 2, 2020
@extrawurst
Copy link
Owner

@tisorlawan thanks again, this is released in 0.8 now: https://github.com/extrawurst/gitui/releases/tag/v0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants