You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Currently when a commit message contains invalid UTF8, the whole message is replaced by the string <unknown>.
To Reproduce
Create a Git commit with a message that contains invalid UTF8.
Expected behavior
I think it would be more useful to use replacement characters (i.e. lossy decoding), so at least most of the commit message is displayed correctly if it only contains a single non-UTF8 character somewhere.
The text was updated successfully, but these errors were encountered:
@Boddlnagg thanks for reporting this, good point! It should be fixed now, but you have no idea how hard it was to force invalid utf8 down rusts safe throat. even the git shell fixed up broken utf8 commit message files. If you could build and test gitui on master to make sure your repro cases are fixed would be awesome!
Describe the bug
Currently when a commit message contains invalid UTF8, the whole message is replaced by the string
<unknown>
.To Reproduce
Create a Git commit with a message that contains invalid UTF8.
Expected behavior
I think it would be more useful to use replacement characters (i.e. lossy decoding), so at least most of the commit message is displayed correctly if it only contains a single non-UTF8 character somewhere.
The text was updated successfully, but these errors were encountered: