-
-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display non-UTF8 commit messages at least partially #150
Comments
@Boddlnagg thanks for reporting this, good point! It should be fixed now, but you have no idea how hard it was to force invalid utf8 down rusts safe throat. even the git shell fixed up broken utf8 commit message files. If you could build and test |
Yes, it works now! Thanks for the quick fix 👍 |
Great! @Boddlnagg thanks for checking! |
released in |
Describe the bug
Currently when a commit message contains invalid UTF8, the whole message is replaced by the string
<unknown>
.To Reproduce
Create a Git commit with a message that contains invalid UTF8.
Expected behavior
I think it would be more useful to use replacement characters (i.e. lossy decoding), so at least most of the commit message is displayed correctly if it only contains a single non-UTF8 character somewhere.
The text was updated successfully, but these errors were encountered: