Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Filter Functionality For the Commits Logs #1790

Closed
AmmarAbouZor opened this issue Aug 4, 2023 · 1 comment
Closed

Add Filter Functionality For the Commits Logs #1790

AmmarAbouZor opened this issue Aug 4, 2023 · 1 comment

Comments

@AmmarAbouZor
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Searching the commits logs via fuzzy finder was always a really wanted feature that couldn't be achieved without sacrificing the performance since we must load all the commits see #1687 #1752.

Describe the solution you'd like

Instead of using fuzzy finder, we can add a filter function (popup with option to search the commit message, description, Author, date from ...to).
After applying the filter we can load the commits as chunks then apply the filter and remove the commits that don't meet it and keep polling new chunks of commits until the view is full (like the current logic).
Additionally we need to add an indicator to the commits log view so the users can see that a filter is currently active and keybinding to remove the filter.

At first I would like to know if this idea could be achievable here, since I'm not familiar enough with the internals and if so then we need to define the filter criteria and the filter indicator in the commits log view

Additional context

For Reference here is a journal app with a basic filter function Tui-Journal. The Implementation there isn't optimized for performance

@extrawurst
Copy link
Owner

duplicate of a handful of issues before. closing in favour of #1791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants