Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat fuzzy find commits #1752

Closed
wants to merge 2 commits into from

Conversation

UUGTech
Copy link
Contributor

@UUGTech UUGTech commented Jul 9, 2023

This Pull Request fixes/closes #1687.

It changes the following:

  • add fuzzy finder for commit list
  • Now, fuzzy find popup uses the list of "{hash} {author} {msg}"
    • Should dates be included or any other better ideas?

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@UUGTech UUGTech marked this pull request as draft July 11, 2023 07:32
@UUGTech
Copy link
Contributor Author

UUGTech commented Jul 11, 2023

The count of logs the commitlist component has is limited.
So you can’t search for old ones.
I wonder how to solve this problem.

@extrawurst
Copy link
Owner

that's exactly what made this feature request so complicated and why it has not been done yet. because its a complex problem to solve. what makes gitui so fast is to not keeping all the commits in memory and only loading a batch that you look at. that means searching the entire history for a commit hash, commit message or anything requires a bunch of mechanisms that are currently not there.

just searching the batch of the log that is currently loaded is potentially misleading

@extrawurst
Copy link
Owner

closing in favour of #1791

@extrawurst extrawurst closed this Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A search in the log for commit
2 participants