Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ignored file didn't append to a new line #191

Closed
leesiongchan opened this issue Jul 10, 2020 · 3 comments
Closed

New ignored file didn't append to a new line #191

leesiongchan opened this issue Jul 10, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@leesiongchan
Copy link

Describe the bug
New ignored file didn't append to a new line

To Reproduce
Steps to reproduce the behavior:

  1. Click 'i' on file
  2. See .gitignore

Expected behavior
Should append to a new line

Screenshots
If applicable, add screenshots to help explain your problem.
image

Context (please complete the following information):

  • OS/Distro + Version: Manjaro
  • GitUI Version 0.8.1
  • Rust version: 1.44

Additional context
Add any other context about the problem here.

@extrawurst extrawurst added the bug Something isn't working label Jul 10, 2020
@extrawurst
Copy link
Owner

hi @leesiongchan thanks for reporting this! unfortunately I cannot reproduce it so far. the potential failure surface is rather small: a problem in writing to the .gitignore file. anyway what you describe is not even 'crashing' the app which means the ignore method does not even literally fail.

I guess I need more help to reproduce it: what folder of your repo did u run gitui in? what file did you try to ignore.
And can you please run gitui with logging enabled and provide it: (see https://github.com/extrawurst/gitui#diagnostics)

@extrawurst extrawurst added the help wanted Extra attention is needed label Jul 10, 2020
@leesiongchan
Copy link
Author

Do you have empty line at last in .gitignore? Try removing it, I am able to reproduce it if my .gitignore isn't end with an empty line

@extrawurst
Copy link
Owner

@leesiongchan now I realise what you mean! thanks! 🙏

@extrawurst extrawurst removed the help wanted Extra attention is needed label Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants