Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate branch re-name #2062

Closed
extrawurst opened this issue Feb 19, 2024 · 2 comments · Fixed by #2081
Closed

validate branch re-name #2062

extrawurst opened this issue Feb 19, 2024 · 2 comments · Fixed by #2081
Labels
feature-request good first issue Good for newcomers
Milestone
v0.25

Comments

@extrawurst
Copy link
Owner

#559 introduced branch name validation for the create-branch path. lets use the same validation method in the rename popup
@sainad2222
Copy link
Contributor

I would like to take a shot at this

@extrawurst
Copy link
Owner Author

extrawurst commented Feb 20, 2024 •
edited
Loading

@sainad2222 great! if you need help find me on mastodon: @rusticorn@fosstodon.org

@sainad2222 sainad2222 mentioned this issue Feb 20, 2024
Merged
4 tasks
@extrawurst extrawurst modified the milestones: v0.26, v0.25 Feb 20, 2024
extrawurst added a commit that referenced this issue Feb 20, 2024
@sainad2222 @extrawurst
feat: add branch name validation on renaming (#2081)
fa051ef 
Closes #2062 

---------

Co-authored-by: extrawurst <776816+extrawurst@users.noreply.github.com>
IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this issue Jun 4, 2024
@sainad2222 @extrawurst @IndianBoy42
feat: add branch name validation on renaming (extrawurst#2081)
ce7a633 
Closes extrawurst#2062 

---------

Co-authored-by: extrawurst <776816+extrawurst@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request good first issue Good for newcomers
Projects
None yet
Milestone
v0.25
Development

Successfully merging a pull request may close this issue.

feat: add branch name validation on renaming sainad2222/gitui
2 participants
@extrawurst @sainad2222