git error:get_string called on a live config object when trying to commit

[c02y]

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. open gitui inside a git repo
2. stage a modified file
3. write a commit message
4. try to commit
5. commit failed, "git error:get_string called on a live config object"

I tried gitui multiple times, failed to commit, but this commit is done successfully using tig.

Expected behavior
commit the commit message successfully

Screenshots
If applicable, add screenshots to help explain your problem.

Context (please complete the following information):

• OS/Distro + Version: [5.7.14-1-MANJARO]
• GitUI Version [0.9.1]
• Rust version: [1.45.2]

Additional context
Add any other context about the problem here.

[extrawurst]

seems related to #79
can you do me a favour and share the config for this repo for the user.name and user.email ?

[c02y]

user.name == empty
user.email == "myemail@email.com"

But it is not saying something like config value 'user.name' was not found;

[extrawurst]

it is exactly the opposite of #79

so it fails if u have a name but no email defined.

[user]
         name = Stephan Dilly

[c02y]

Yes, I get it now, but I used tig to commit it successfully, which is weird, since user.name can be undefined in the commit step.

I think we can treat this issue an bug of gitui

[cruessler]

If this is not taken yet, I’d have a look.

[extrawurst]

@cruessler sure! 👍

[extrawurst]

@cruessler any progress on this? I am thinking about cutting a release to get the vim key bindings out the door

[cruessler]

@extrawurst Sorry for the delay. I’ll now start working on it.

[cruessler]

@c02y Running git commit with user.email not set fails on my machine both using git and tig with the exact same error message: *** Please tell me who you are. If I am not overlooking anything, gitui could improve on its error message, but does not do anything unusual.

❯ git --version
git version 2.25.1

testrepo on master [+]
❯ tig -v
tig version 2.4.1
ncursesw version 6.2.20200212
readline version 8.0

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[dgrine]

+1

[extrawurst]

#269 actually fixes this, but having reliable tests for this is a pickle, but hey lets just bite that bullet