-
-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The commit function does not work when you have user.email but no user.name defined #79
Comments
followup to #74 |
unfortunately #155 had to be rolled back |
removed |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
still active: #269 |
@cruessler is this fixed by your PR? |
@alistaircarscadden @cruessler closing this hoping that #269 actually fixed this. please reopen if this is not the case |
Describe the bug
In gitui v0.3.0 the commit function does not allow a commit to be made when the user has a user.email defined and no user.name defined.
It took me a while to discover that there is a difference between user.name being defined as empty (
git config user.name ""
) and it being undefined (as in,git config --list
does not show the entry at all).In the empty case, interestingly enough, git commit does not allow the commit to be made, likewise gitui does not allow it.
In the undefined case, git commit does allow the commit to be made (and I think it shows
unknown
in that field in latergit log
orgit show
calls). This is where the gitui behaviour is different, as gitui does not allow a commit to be made with this message:Expected behavior
gitui would allow a commit to be made and fill in
unknown
as git commit does.The text was updated successfully, but these errors were encountered: