allow undefined user.name on commit #155
Conversation
mxork
force-pushed
the
signature-allow-undefined-name
branch
from
354102a
to
63775f0
Compare
mxork
force-pushed
the
signature-allow-undefined-name
branch
from
63775f0
to
1381107
Compare
|
@mxork thanks for fixing this! 🥳 |
|
@mxork did you try coming up with a unites for this? I am struggling with this |
|
@mxork I need to roll this back I think, it keeps failing for me and I am wondering how you managed to get |
|
@mxork see here for the failing CI: https://github.com/extrawurst/gitui/runs/816484457 |
|
@mxork I am sorry I had to revert this, but I should have checked it out more thorough in the first place. It would be awesome if you could update it using This seems to be one of those implementations where writing the test by far outweighs writing the feature itself 🙈 |
|
This absolutely should have had a big WIP on the front of it.
I'll try to figure out a test. Sorry you spent time chasing it around.
…On Mon, Jun 29, 2020, 3:58 AM Stephan Dilly ***@***.***> wrote:
@mxork <https://github.com/mxork> I am sorry I had to revert this, but I
should have checked it out more thorough in the first place. It would be
awesome if you could update it using get_entry (or any other config
method that works on non-snapshots unlike get_str see docs
<https://libgit2.org/libgit2/#HEAD/group/config/git_config_get_string>)
and most importantly have a working unittest.
This seems to be one of those implementations where writing the test by
far outweighs writing the feature itself 🙈
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#155 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASXHDCSA5MUTKQZSP2UEMLRZBCRDANCNFSM4OKE2WGA>
.
|
|
@mxork no worries! happy you wanna contribute. Feel free to join the discord to simplify discussion: https://discord.gg/7TGFfuq |
fixes #79