-
-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest moving theme.ron from XDG_CACHE_HOME to XDG_CONFIG_HOME #98
Labels
Comments
good point sounds reasonable! |
extrawurst
added
enhancement
New feature or request
good first issue
Good for newcomers
labels
May 30, 2020
jonstodle
added a commit
to jonstodle/gitui
that referenced
this issue
Jun 14, 2020
This changes the config directory from the `dirs::cache_dir` to `dirs::config_dir`. It does however keep the cache directory as the default logging directory, as it seems a better fit. It also adds a function, `migrate_config`, which is called at startup to move directory entries inside the "old" config directory to the "new" one (but it skips moving log files). The intention is that this function can be removed after a few releases when the likelihood of someone upgrading from 0.6.0 or earlier is fairly small. Fixes extrawurst#98
Merged
extrawurst
pushed a commit
that referenced
this issue
Jun 14, 2020
This changes the config directory from the `dirs::cache_dir` to `dirs::config_dir`. It does however keep the cache directory as the default logging directory, as it seems a better fit. It also adds a function, `migrate_config`, which is called at startup to move directory entries inside the "old" config directory to the "new" one (but it skips moving log files). The intention is that this function can be removed after a few releases when the likelihood of someone upgrading from 0.6.0 or earlier is fairly small. Fixes #98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to #27
The spec notes:
The non-essential bit there means this data can be purged at any point without impacting the user.
theme.ron
being user data probably should be preserved, which suggests it should be in"$XDG_CONFIG_HOME/gitui/theme.ron"
The text was updated successfully, but these errors were encountered: