Make MsgPopup scrollable #2120
Merged
Make MsgPopup scrollable #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
somehow i cannot get this to work if I checkout your branch: Screenflick.Movie.22.mp4 |
If gitui window shrinks below set height, scrollbar will correctly be displayed and text will scroll correctly. Fix panic when clamping width if f.size().width went below MINIMUM_WIDTH.
|
The scrolling should work correctly now when shrinking the window |
|
it only uses the original messages lines count and not the number of lines that happen to be shown when the text wraps at places because it is wider than the message box: |
extrawurst
reviewed
Mar 20, 2024
extrawurst
reviewed
Mar 20, 2024
Now if the window shrinks below defined width, the message lines will wrap correctly. Allow words to be split (broken) to fit the rect size by using wrap_maybrk. Handle panic if msg is an empty string.
It should now use the correct width for text wrapping |
|
looks good now! thanks @MichaelAug |
IndianBoy42
pushed a commit
to IndianBoy42/gitui
that referenced
this pull request
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #1138.
It changes the following:
I followed the checklist:
make checkwithout errors