Add test for AsyncLog respecting GIT_DIR #2387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #2301. It adds a test for
AsyncLog::fetch_helper_without_filter
respectingGIT_DIR
. The docs tostd::env::set_var
say that it is only safe to be used in single-threaded programs. Could this ever become an issue? On my machine,make check
was green.(Creating snapshot tests running the
gitui
binary has proven to be rather challenging. So far, I have not found a crate that would work withenable_raw_mode
which is why I decided to open this PR.)