Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: help popup display viewing progress #2388

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

wugeer
Copy link
Contributor

@wugeer wugeer commented Oct 15, 2024

It changes the following:

  • help popiup page show viewing progress

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

before
gitui_help_popup_before.webm

after
gitui_help_popup_after.webm

@extrawurst
Copy link
Owner

Thanks for looking into this. The gitui idiomatic way to show progress on a vertical scroll though is using a scrollbar. so I would suggest we integrate that here too. feel free to join our discord to discuss there things upfront in the future to not waste any effort.

@wugeer
Copy link
Contributor Author

wugeer commented Oct 15, 2024

In my personal view, having a percentage-based progress might make it a bit easier to understand. :)
It seems that when scrolling up and down on this page, I didn’t notice a scrollbar on the right side.
image
Also, I’ll create a Discord account a bit later.

@wugeer
Copy link
Contributor Author

wugeer commented Oct 16, 2024

@extrawurst I'll try to add a scrollbar on the right, similar to the one in a browser.:)

@extrawurst
Copy link
Owner

Browser?

Just use the same code we use everywhere else do scroll bars in for example the log tab

@wugeer
Copy link
Contributor Author

wugeer commented Oct 16, 2024

Yes, I will try it. :)
image

@wugeer
Copy link
Contributor Author

wugeer commented Oct 16, 2024

@extrawurst Have Done!

@extrawurst
Copy link
Owner

extrawurst commented Oct 16, 2024

looking good! i wonder why you have different formatting - lets see what the ci says about that

edit: it fails on the formatting. please make sure to use the latest rust stable

@wugeer
Copy link
Contributor Author

wugeer commented Oct 16, 2024

My bad, my local environment was on an unstable version. I switched to the stable version of Rust, and cargo clippy works fine.

@extrawurst extrawurst merged commit fb1ba7c into extrawurst:master Oct 18, 2024
20 of 21 checks passed
@extrawurst
Copy link
Owner

Thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants