Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set MacOS config directory to ~/.config #379

Merged
merged 3 commits into from
Feb 16, 2021
Merged

Conversation

remique
Copy link
Contributor

@remique remique commented Oct 27, 2020

Hello again :) This fixes #317. I have noticed that no one is working on it, and it seems relatively easy to fix.

Everyone in #317 agreed that Mac config should be kept inside ~/.config/ instead of ~/Library/Application Support/.

So now gitui config files will be kept inside:

  • MacOS: ~/.config
  • Linux: ~/.config or $XDG_CONFIG_HOME
  • Windows: {FOLDERID_RoamingAppData}

Did not test it on anything but Mac though.

@extrawurst
Copy link
Owner

I am going to wait with anything that is non 0.11 milestone related until after the release now. the release will take forever otherwise - any chance u might find one of the 0.11 issues interesting to dig into ?

@remique
Copy link
Contributor Author

remique commented Oct 27, 2020

Oki, that makes sense. I will look into the 0.11 issues 👍

@extrawurst
Copy link
Owner

@remique don't get me wrong any contribution is appreciated❤️. I will just not merge them before the next release

@extrawurst
Copy link
Owner

@remique that took way longer to come back to than I hoped.
we need add this to the CHANGELOG.md and KEY_CONFIG.md before I can merge this

@extrawurst extrawurst marked this pull request as draft February 6, 2021 13:28
@shawnohare
Copy link

I can't wait to see this merged :)

@remique
Copy link
Contributor Author

remique commented Feb 16, 2021

Sorry for the delay guys :)

@extrawurst
Copy link
Owner

@remique yeah you can merge commits using git rebase (squash)

@extrawurst extrawurst marked this pull request as ready for review February 16, 2021 21:50
@extrawurst extrawurst merged commit b5411e2 into extrawurst:master Feb 16, 2021
extrawurst pushed a commit that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thoughts on checking ~/.confg/gitui or $XDG_CONFIG_HOME/gitui on mac before defaulting to the existing dir?
3 participants