Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better explanation how to configure external editor (#382) #400

Closed

Conversation

akshay1992kalbhor
Copy link

Any suggestions will be appreciated. This is kind of a first draft.

@WizardOhio24
Copy link
Contributor

Thanks for the PR.
With this, should it not show the user the actual error because it might not be that GIT_EDITOR is not set, it could be something entirely different, I mean, in the original issue it said vi could not be found, but that could be for a number of reasons, not just GIT_EDITOR.
I'd say as well, it should include "and the editor is installed and valid.", if the user doesn't have micro installed, they can't use micro, no matter if GIT_EDITOR is set.

So, the error message then tells the user the most common way to fix it, but also shows the user the error.

What do you think?

@extrawurst
Copy link
Owner

@akshay1992kalbhor thanks for your interest in supporting gitui.
can you check the new behaviour for when some editor env variable is empty: 156776a

for the time being I mark this as draft

@extrawurst
Copy link
Owner

extrawurst commented Dec 27, 2021

seems unmaintained, feel free to update and re-open

@extrawurst extrawurst closed this Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants