code.editor config ignored

[pm100]

#414

This PR fixes all 3 issues in the original bug

• gitui does not look at code.editor setting
• git2 config.get_str always fails
• gitui doesnt like editors with spaces in their names (vscode sets itself in core.editor)

does not fix the potential error of editors setting with spaces in the args (as noted in the original comments)

does not change the other places where get_str is called - it probably should

I wanted to add a test for trying to read config str with non UTF8 string name (since this is a failure mode for git2) but this project bans unsafe. unsafe is needed to be able to create an illegal utf8 string

Also note that the code working with config.get_entry does not work how the git2 docs say it should (what errors occur when etc) but it actually works.

Finally: Reviewers, I am still learning my way around rusts idioms and would welcome feedback on how this code can be improved. In particular all the or_else, and_then, if_you_like ,... chaining

[WizardOhio24]

@pm100 You have included all the commits for fixing the missing cursor at the end of the line 😧, you might want to cherry pick this onto a new branch then force push that here.

[WizardOhio24]

With the above code, a more rust way to write this might be:

    if let Some(value) = repo.config()?.get_entry(key)?.value() {
        return Ok(Some(String::from(value)));
    }
    Ok(None);

If anyone else has any suggestions feel free.

[pm100]

@WizardOhio24 aha, total git noob here (so why am i working on gitui, cos I like tui projects). I think i know my mistake. In my mind 'git branch foo' makes a new clean branch . I subconsciously though that it would be from master.

I assume I have to go

• get checkout master
• git branch foo
• git checkout foo

Is there a magic command (rebase?) that will sort this out for me.

I will sort this out before looking at your other suggestions