-
-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support force push #421
Support force push #421
Conversation
This reverts commit de4ea26.
I added the confirm popup but the confirm box seems a bit small, I'll increase it's size. |
I think this can be merged(pending review), @extrawurst? The only thing is that it does not use the correct upstream branch at the moment, it uses the fact that the upstream must be named the same as the local in currently (in GitUI), so this will have to be changed when a upstream with a different name is supported. |
@WizardOhio24 why do you close these? |
did not have time to review them yet. still working myself through the PRs since yesterday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WizardOhio24 I think for force
we should implement the finding of the remote name instead of simply assuming it is the same as the local branch. in case of force this could otherwise lead to bad surprises, don't you think?
This now force pushes to the same place as a normal push would go to, which I think is just the set upstream repo. |
@WizardOhio24 thanks man!❤️ |
Closes #274
This currently force pushes (with SHIFT+P) but does not ask the user to confirm their action, I'll implement that as well.