Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation of fill var not happening after the first tap #462

Closed
aure opened this issue Aug 20, 2018 · 4 comments
Closed

Animation of fill var not happening after the first tap #462

aure opened this issue Aug 20, 2018 · 4 comments
Milestone

Comments

@aure
Copy link
Contributor

aure commented Aug 20, 2018

When I add tap to a group, the first time I see the nice background animation, but afterwards I don't see anything. I do get the "tap!" printed to the log, so I know the tap is being registered. I'd be happy to submit a pull request if you can give me a hint where to look.

    group.onTap { _ in
        print("tap!")
        self.valueBG.fillVar.animate(from: Color.white, to: Color(val: 0x333333), during: 0.1)
    }
@ystrot ystrot added this to the 0.9.3 milestone Aug 20, 2018
@f3dm76
Copy link
Collaborator

f3dm76 commented Aug 20, 2018

Thank you very much for pointing out this flaw. We will work on that in the nearest future and let you know as soon as it's done.

@ystrot ystrot closed this as completed in 8bf5f64 Aug 23, 2018
ystrot added a commit that referenced this issue Aug 23, 2018
Fix #462: Animation of fill var not happening after the first tap
@f3dm76
Copy link
Collaborator

f3dm76 commented Aug 23, 2018

aure, issue is fixed in the master branch, you're welcome to check it out. Thanks again!

@aure
Copy link
Contributor Author

aure commented Aug 23, 2018

Thanks I'll give it a try!

@aure
Copy link
Contributor Author

aure commented Aug 23, 2018

So actually I get the following error now, right after the tap! is printed:

Fatal error: Equatable can't be realised for  Fill: file /Users/aure/Developer/aure/Macaw/Source/model/draw/Fill.swift, line 7
2018-08-23 12:23:05.433468-0700 SuperSequencer[592:409325] Fatal error: Equatable can't be realised for  Fill: file /Users/aure/Developer/aure/Macaw/Source/model/draw/Fill.swift, line 7

f3dm76 added a commit to f3dm76/Macaw that referenced this issue Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants