-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quadratic path support #157
Conversation
Nope, doesn't work even on simple examples:
I will try to have a closer look but seems like the TODO in code needs to be addressed :) |
@kayuri I just updated the example and SVGView to allow setting an external url (easier to test local files from the example and it's a useful feature anyway). Beside the incorrect inferred bounds, it seems to work properly on your example. I can look at why the bounds are incorrect in the first place, unclear whether this is related to my change though. |
@kayuri Example with bounding box working. In the latest commit I'm using CGPath boundingBox instead of the custom calculation code. You may have good reasons why you made that code in the first place, let me know if you want me to revert that change. |
@rFlex yep, I got similar views, though that bounds issue was caused by the the change though. Will give it some more thought. Thanks! |
@kayuri yes it's because it was missing the implementation to return the bounds from a Q/q Path, which causes problems when trying to scale the view. |
Hi Simon, Generally your patch looks good. Could you please update it to the latest version and avoid merge conflicts? |
Hi Simon, Unfortunately we were unable to apply your patch, because it was outdated. However we implemented quadratic segments (including q/Q/t/T types) and it's already in the master and will be part of 0.9.2 release. |
Support for Q path. Unclear whether q will properly work with this change, I don't have an example that uses it unfortunately :(.