Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text bounds fix and additional options for Baseline #245

Closed
wants to merge 6 commits into from
Closed

Text bounds fix and additional options for Baseline #245

wants to merge 6 commits into from

Conversation

JoachimM7
Copy link
Contributor

No description provided.

@ystrot
Copy link
Member

ystrot commented Dec 8, 2017

Thank you a lot for your work! It would be better to split pull requests by task. There are three different tasks in this request:

@JoachimM7
Copy link
Contributor Author

Ok. I will create two new pull requests, one for fix #241 and for the Documentation I will create a new branch and there I can add my DocStrings step by step (but this needs time, I still do not understand everything in Macaw, luckily the code is very vell readable!)

@JoachimM7 JoachimM7 closed this Dec 8, 2017
@JoachimM7 JoachimM7 deleted the text_bounds_fix branch December 8, 2017 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants