-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix up relations of memory.hpp and multi_wrapper_impls/memory.hpp #417
Labels
Comments
eyalroz
added a commit
that referenced
this issue
Oct 6, 2022
… fixes: * Removed `inline` from declarations with no definitions in `memory.hpp` * Moved `memory::set()` to `multi_wrapper_impls/memory.hpp` * Spacing tweaks
eyalroz
added a commit
that referenced
this issue
Oct 6, 2022
… fixes: * Removed `inline` from declarations with no definitions in `memory.hpp` * Moved `memory::set()` to `multi_wrapper_impls/memory.hpp` * Spacing tweaks
eyalroz
added a commit
that referenced
this issue
Oct 7, 2022
… fixes: * Removed `inline` from declarations with no definitions in `memory.hpp` * Moved `memory::set()` to `multi_wrapper_impls/memory.hpp` * Spacing tweaks
eyalroz
added a commit
that referenced
this issue
Oct 7, 2022
… fixes: * Removed `inline` from declarations with no definitions in `memory.hpp` * Moved `memory::set()` to `multi_wrapper_impls/memory.hpp` * Spacing tweaks
eyalroz
added a commit
that referenced
this issue
Oct 7, 2022
… fixes: * Removed `inline` from declarations with no definitions in `memory.hpp` * Moved `memory::set()` to `multi_wrapper_impls/memory.hpp` * Spacing tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some functions declared
memory.hpp
need code frompointer.hpp
or elsewhere - so their definitions should be withinmulti_wrapper_impls
, and their declarations should not beinline
. Both of these conditions are not always met...cuda::memory::set()
needs to be moved, and a couple of declarations need to lose theirinline
.The text was updated successfully, but these errors were encountered: